Improve test coverage to ~100% for @azure/core-lro by deyaaeldeen · Pull Request #38178 · Azure/azure-sdk-for-js

deyaaeldeen · 2026-04-16T23:50:07Z

Changes

New test files

buildCreatePoller.spec.ts
http-operation.spec.ts
pollHttpOperation.spec.ts
poller-state-guard.spec.ts
pollerInternals.spec.ts

Expanded existing tests

lro.spec.ts: serialization/restore, submitted(), polling intervals, error states
rewriteUrl.spec.ts: undefined URL handling

Test quality improvements

Replaced pollCount/setState/check flags with vi.fn() + toHaveBeenCalledTimes()
Replaced non-null assertions (operationState!) with optional chaining after guards
deepEqual on primitives changed to strictEqual
assert.equal(x, undefined) changed to assert.isUndefined(x)
.mock.calls.length changed to expect matchers

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Split poller-poller.spec.ts: - test/public/poller.spec.ts: 12 tests using createTestPoller/createHttpPoller - test/internal/poller-poller.spec.ts: 7 tests using internal helpers Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Deduplicate makeRawResponse (5 files) and makeState (4 files) into test/utils/utils.ts. All 347 tests pass with build-test clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move 5 tests that only use createTestPoller (public API) from test/internal/poller-operation.spec.ts to test/public/poller.spec.ts. Internal file retains 6 tests that use internal APIs (deserializeState, pollOperation, initOperation, buildCreatePoller). All 347 tests pass with build-test clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- poller-poller.spec.ts → buildCreatePoller.spec.ts - poller-operation.spec.ts → pollerInternals.spec.ts - http-poller.spec.ts → pollHttpOperation.spec.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR expands the @azure/core-lro test suite with additional internal and public tests to drive overall coverage toward ~100%, including new tests around poller internals, HTTP operation behavior, and additional rewriteUrl error-path coverage.

Changes:

Added new internal unit tests for poller internals (buildCreatePoller, pollOperation, state-guard behavior) and HTTP operation helpers.
Extended public LRO tests to exercise additional createHttpPoller behaviors (operation-location callbacks, resolve-on-unsuccessful paths, error formatting).
Extended rewriteUrl tests to cover invalid base URL / relative URL resolution error handling.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
sdk/core/core-lro/test/utils/utils.ts	Adds shared test helpers for constructing `RawResponse` and operation state objects.
sdk/core/core-lro/test/public/lro.spec.ts	Adds a large `createHttpPoller` test suite covering additional polling and error scenarios.
sdk/core/core-lro/test/internal/rewriteUrl.spec.ts	Adds an additional negative test for `rewriteUrl` error handling.
sdk/core/core-lro/test/internal/pollerInternals.spec.ts	Introduces tests for poller operation internals (`deserializeState`, `pollOperation`, `initOperation`).
sdk/core/core-lro/test/internal/poller-state-guard.spec.ts	Adds tests for defensive “state must be initialized” guards in the poller.
sdk/core/core-lro/test/internal/pollHttpOperation.spec.ts	Adds a focused test for `pollHttpOperation` default `processResult` behavior.
sdk/core/core-lro/test/internal/http-operation.spec.ts	Adds broad unit tests for HTTP operation helpers (mode inference, status/error parsing, retry-after handling).
sdk/core/core-lro/test/internal/buildCreatePoller.spec.ts	Adds tests for Body/ResourceLocation status handling and a polling interval path.

- Remove brittle line numbers from test names in poller-state-guard - Rename misleading isDone describe block in pollerInternals - Rename setDelay test to match actual behavior in buildCreatePoller - Use non-zero retry-after value (1) to properly exercise setDelay branch - Run format Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ientHelpers tests The find() callback already matches by policy name, so asserting strictEqual on .name after isDefined is redundant. Also simplifies the assertions by inlining find() into isDefined. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- serviceClient.spec.ts: Replace weak assert.isDefined with specific assertions verifying Invalid Date instance for malformed DateTime string - authorizeRequestOnTenantChallenge.spec.ts: Fix const->let for calledOnce variable so both if/else branches are exercised in mock Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…m status, and retry-after - Assert getPollingInterval callback is actually invoked (buildCreatePoller.spec.ts) - Assert getStatusFromPollResponse callback is actually invoked (pollerInternals.spec.ts) - Rename retry-after test to accurately describe smoke test behavior (lro.spec.ts) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…test-coverage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Replace weak assertions with stronger alternatives - Remove redundant isDefined before deepEqual - Fix misleading test name Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ing test - Fix misleading 'setErrorAsResult is true' title (was actually false) - Add state assertion to 'sets state to failed' test - Strengthen innererror chain test to verify message concatenation - Verify milliseconds scale in retry-after date test - Add 'missing code' test case for getErrorFromResponse - Replace pollCount with spy for consistency - Shorthand property nit in buildCreatePoller test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Improve test coverage to ~100% for @azure/core-lro

a201222

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions Bot added the Azure.Core label Apr 16, 2026

Deyaaeldeen Almahallawi and others added 14 commits April 17, 2026 00:09

Remove 'coverage' from test describe block names

8109455

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove 'edge cases' from describe block names

0b796b1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Strengthen isDefined-only assertions with value checks

5350c62

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move imports to top level (vitest hoists vi.mock automatically)

57b9c74

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix TypeScript compilation errors caught by CI

e8ac8ea

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Extract makeRawResponse and makeState to shared test utils

3876c44

Deduplicate makeRawResponse (5 files) and makeState (4 files) into test/utils/utils.ts. All 347 tests pass with build-test clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Clean up imports: combine duplicates, prefer src/index.js (core-lro)

392aa23

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove old test files after rename

74d290e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove unnecessary comments from test files (core-lro)

1207617

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge poller.spec.ts into lro.spec.ts (core-lro)

351d245

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Delete poller.spec.ts (merged into lro.spec.ts)

141baa3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

deyaaeldeen marked this pull request as ready for review April 17, 2026 19:24

deyaaeldeen requested review from a team and joheredi as code owners April 17, 2026 19:24

Copilot AI review requested due to automatic review settings April 17, 2026 19:24

Copilot started reviewing on behalf of deyaaeldeen April 17, 2026 19:25 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

deyaaeldeen pushed a commit that referenced this pull request Apr 17, 2026

Address PR #38178 review feedback: fix test names and retry-after value

98f7b37

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Deyaaeldeen Almahallawi and others added 2 commits April 17, 2026 23:34

deyaaeldeen requested a review from timovv as a code owner April 17, 2026 23:34

Deyaaeldeen Almahallawi and others added 3 commits April 17, 2026 23:38

Merge remote-tracking branch 'origin/main' into deyaaeldeen/core-lro-…

c36a532

…test-coverage

fix: merge main and remove dead getCachedDefaultHttpsClient test

a4e5372

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Deyaaeldeen Almahallawi and others added 11 commits April 18, 2026 02:40

fix: address audit issues in core-lro tests

d41f580

- Replace weak assertions with stronger alternatives - Remove redundant isDefined before deepEqual - Fix misleading test name Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: use isAtLeast in tokenCycler test

5f50252

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: use assert.strictEqual instead of assert.isTrue(x === y) in lro …

6170eb9

…tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: strengthen isDefined to assert actual value in lro state tests

f604f87

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor: replace non-null assertions with optional chaining in lro t…

7d87337

…ests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor: modernize spy patterns in core-lro tests

305485e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor: second pass modernization in core-lro tests

42879ea

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: resolve TS2339 on operationState?.status in lro tests

086c2ec

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor: third pass modernization in core-lro tests

96318e3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: remove foreign package files from core-lro branch

fe10246

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Eliminate unnecessary type casts in core-lro tests

d9dceb3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jeremymeng reviewed Apr 21, 2026

View reviewed changes

Deyaaeldeen Almahallawi and others added 2 commits April 21, 2026 17:36

fix: align test title with actual assertion in http-operation.spec.ts

61ae359

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

deyaaeldeen requested review from a team and xirzec as code owners April 21, 2026 18:12

Deyaaeldeen Almahallawi and others added 2 commits April 21, 2026 18:12

Remove stale temp file

fb7e547

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add idempotency comment on duplicate poll assertion

a42c3c6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

deyaaeldeen requested a review from jeremymeng April 21, 2026 18:23

Add idempotency comment on canceled poll assertion

62bd399

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jeremymeng approved these changes Apr 21, 2026

View reviewed changes

deyaaeldeen merged commit 9a7b808 into main Apr 21, 2026
13 checks passed

deyaaeldeen deleted the deyaaeldeen/core-lro-test-coverage branch April 21, 2026 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve test coverage to ~100% for @azure/core-lro#38178

Improve test coverage to ~100% for @azure/core-lro#38178
deyaaeldeen merged 37 commits intomainfrom
deyaaeldeen/core-lro-test-coverage

deyaaeldeen commented Apr 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

deyaaeldeen commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

New test files

Expanded existing tests

Test quality improvements

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

deyaaeldeen commented Apr 16, 2026 •

edited

Loading